Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: added reconnect logic for web sockets #35

Merged
merged 2 commits into from
Jun 19, 2024
Merged

fix: added reconnect logic for web sockets #35

merged 2 commits into from
Jun 19, 2024

Conversation

yevhen-burkovskyi
Copy link
Contributor

No description provided.

@yevhen-burkovskyi yevhen-burkovskyi self-assigned this Jun 19, 2024
@coderabbitai coderabbitai
Copy link

coderabbitai bot commented Jun 19, 2024 •
edited
Loading

Warning

Review failed

The pull request is closed.

Walkthrough

The recent update to the Okp4Service class introduces two new private properties for managing WebSocket connections and reconnection attempts. Additionally, the connectToNewBlockSocket method has been refactored to enhance the handling of WebSocket connections, including improved event handling and error logging.

Changes

File Change Summary
src/core/lib/okp4/okp4.service.ts Added private socket!: WebSocket; and private reconnectAttempts = 1;. Refactored connectToNewBlockSocket method to manage WebSocket connections and reconnections, along with event handling and error logging.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

coderabbitai[bot]
coderabbitai bot reviewed Jun 19, 2024
View reviewed changes
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between f76bc26 and d878d7c.

Files selected for processing (1)
  • src/core/lib/okp4/okp4.service.ts (6 hunks)
Additional context used
Biome
src/core/lib/okp4/okp4.service.ts

[error] 178-179: Change to an optional chain. (lint/complexity/useOptionalChain)

Unsafe fix: Change to an optional chain.

[error] 200-200: Use the '**' operator instead of 'Math.pow'. (lint/style/useExponentiationOperator)

Unsafe fix: Use the '**' operator instead of 'Math.pow'.

Additional comments not posted (3)
src/core/lib/okp4/okp4.service.ts (3)

31-32: Added two new private properties socket and reconnectAttempts to manage WebSocket connections.

Line range hint 151-193: Refactored connectToNewBlockSocket to manage WebSocket connections more robustly, including event handling and reconnection logic.

Tools
Biome

[error] 178-179: Change to an optional chain. (lint/complexity/useOptionalChain)

Unsafe fix: Change to an optional chain.

[error] 200-200: Use the '**' operator instead of 'Math.pow'. (lint/style/useExponentiationOperator)

Unsafe fix: Use the '**' operator instead of 'Math.pow'.

179-180: Consider using optional chaining to simplify the code.

- if (jsonData && jsonData?.result && jsonData?.result?.query === "tm.event='NewBlock'")
+ if (jsonData?.result?.query === "tm.event='NewBlock'")

Likely invalid or redundant comment.

src/core/lib/okp4/okp4.service.ts Outdated Show resolved Hide resolved
@yevhen-burkovskyi yevhen-burkovskyi requested a review from DraugS June 19, 2024 10:44
@yevhen-burkovskyi yevhen-burkovskyi merged commit 8b6754c into main Jun 19, 2024
11 checks passed
@yevhen-burkovskyi yevhen-burkovskyi deleted the fix/websocket-reconnect-logic branch June 19, 2024 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments

@DraugS DraugS DraugS approved these changes

Assignees

@yevhen-burkovskyi yevhen-burkovskyi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yevhen-burkovskyi @DraugS